Skip to content

Fix inheritance, add seaport validator, refactor API/Types #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 18, 2023
Merged

Fix inheritance, add seaport validator, refactor API/Types #3

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
42e07b7
refactor: support for react-hooks
nickadamson Oct 17, 2023
f8e4aaa
fix: type annotations
nickadamson Oct 17, 2023
a024b24
chore: fix exports
nickadamson Oct 17, 2023
26d6d57
refactor: add seaport validator + switch class inheritance
nickadamson Oct 17, 2023
df75797
Update src/entities/contracts/seaport.ts
nickadamson Oct 17, 2023
4da71eb
refactor: async from initializers on option entities
nickadamson Oct 17, 2023
51248c2
refactor: hoist opening of stream up to base-trader
nickadamson Oct 17, 2023
2b186f0
refactor: use dynamic getters to simplify interface
nickadamson Oct 17, 2023
918eb77
refactor: spender type
nickadamson Oct 17, 2023
6c6a86c
refactor: remove exercise/redeem from trader class
nickadamson Oct 18, 2023
1dfc83f
fix: use class client for erc20 contract simulations
nickadamson Oct 18, 2023
71310ec
chore: lint/format
nickadamson Oct 18, 2023
15ba838
Merge remote-tracking branch 'origin/main' into refactor-for-hooks
nickadamson Oct 18, 2023
9742659
FIX: option/claim inheritance
nickadamson Oct 18, 2023
56d9ef6
ci: edit workflow
nickadamson Oct 18, 2023
942c182
chore: cleanup
nickadamson Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: spender type
  • Loading branch information
@nickadamson
nickadamson committed Oct 17, 2023
commit 918eb7791da2d6a2b3e07ff734620ea9dc99eecb
6 changes: 4 additions & 2 deletions src/entities/trader/base-trader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ export interface TraderConstructorArgs {
chain: Chain;
}

type Spender = typeof CLEAR_ADDRESS | typeof SEAPORT_ADDRESS;

export class Trader {
public account: Account;
public chain: Chain;
Expand Down Expand Up @@ -250,7 +252,7 @@ export class Trader {
amount,
}: {
erc20: ERC20Contract;
spender: typeof CLEAR_ADDRESS | typeof SEAPORT_ADDRESS;
spender: Spender;
amount: bigint;
}) => {
const approvedAmount = await this.getAllowanceFor({ erc20, spender });
Expand All @@ -272,7 +274,7 @@ export class Trader {
spender,
}: {
erc20: ERC20Contract;
spender: typeof CLEAR_ADDRESS | typeof SEAPORT_ADDRESS;
spender: Spender;
}) => {
const cachedAllowance = this.erc20Allowances.get(erc20.address)?.[spender];
if (cachedAllowance) {
Expand Down