Skip to content

fix: peer deps #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 30, 2023
Merged

fix: peer deps #5

merged 4 commits into from
Nov 30, 2023

Conversation

nickadamson
Copy link
Collaborator

No description provided.

@nickadamson nickadamson marked this pull request as ready for review November 30, 2023 08:04
@nickadamson nickadamson self-assigned this Nov 30, 2023
albertocevallos
albertocevallos approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@albertocevallos albertocevallos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging it in, gonna create a branch from this commit to include some changes.

@albertocevallos
Copy link
Contributor

albertocevallos commented Nov 30, 2023 •
edited
Loading

Btw @nickadamson did you test if it actually doesn't re-render?

I re-did the hook in the frontend repo, gonna port over the logic here.

I think we should spec out the useStream and useRFQ to release a beta version. We should re-introduce usePrice once the backend supports it.

@albertocevallos albertocevallos merged commit 0957cb1 into main Nov 30, 2023
@nickadamson nickadamson deleted the solve-peer-deps branch December 6, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertocevallos albertocevallos albertocevallos approved these changes

Assignees

@nickadamson nickadamson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickadamson @albertocevallos