Feat add container to modal options #6571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(modal): Add container property to ModalOptions These changes will allow developers to optionally place render modals within the application context, allowing components injected via BsModalService to use ViewEncapsulation and support change detection. * Added container<string | ElementRef> property to ModalOptions. * Updated modalConfigDefaults with "container: 'body' " to prevent breaking changes/behavior * Updated BsModalService and Modal-Directive so that the container element is no longer hard-coded to 'body' but rather config.container
Updated documentation pages Updated test case for ModalOptions.container property
These changes will allow developers to optionally place render modals within the application context, allowing components injected via BsModalService to use ViewEncapsulation and support change detection. * Added container<string | ElementRef> property to ModalOptions. * Updated modalConfigDefaults with "container: 'body' " to prevent breaking changes/behavior * Updated BsModalService and Modal-Directive so that the container element is no longer hard-coded to 'body' but rather config.container
|
@valorkin @SvetlanaMuravlova Tagging you two because you are the people with the most recent activity. These changes would solve a lot of headaches for me. I work for a company that has a very large application with dozens of modals with customizations which use ViewEncapsulation.None because modals are hardcoded to be appended to the body. The lack of view encapsulation has caused a lot of problems depending on which dev on our team codes the modal... I'd rather use this existing codebase instead of writing my own separate solution. I'm certainly open to hearing if my approach here needs adjusting.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.