fix(popover): add fallback value if parseFloat on css fails #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow positioning for certain corner placements on popover fails on firefox (possibly other non-webkit browsers). In this case, parseFloat() returns NaN and resulting in all operations to be converted to NaN. Adding fallback to 0 in case the parseFloat returns NaN
Codecov Report
@@ Coverage Diff @@
## development #6196 +/- ##
===============================================
- Coverage 77.55% 77.51% -0.04%
===============================================
Files 302 302
Lines 10549 10549
Branches 2499 2583 +84
===============================================
- Hits 8181 8177 -4
- Misses 2358 2362 +4
Partials 10 10
Continue to review full report at Codecov.
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
daniloff200
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow positioning for certain corner placements on popover fails on firefox (possibly other non-webkit browsers). In this case, parseFloat() returns NaN and resulting in all operations being converted to NaN. Adding fallback to 0 in case the parseFloat returns NaN.
Closes #5908
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.