Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typeahead onBlur initial error for async loaded list #6028

Merged

Conversation

lukasz-madej
Copy link
Contributor

No description provided.

…blur` handler

This happens on first use of the component (after the render) in case the `list` data was loaded asynchronously. Currently this results in a `TypeError: Cannot read property 'length' of undefined` error.
@valorkin valorkin self-assigned this May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #6028 (065246e) into development (b6bb985) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6028      +/-   ##
===============================================
- Coverage        77.55%   77.51%   -0.04%     
===============================================
  Files              302      302              
  Lines            10549    10549              
  Branches          2583     2583              
===============================================
- Hits              8181     8177       -4     
- Misses            2358     2362       +4     
  Partials            10       10              
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 84.84% <100.00%> (ø)
src/chronos/i18n/pl.ts 85.00% <0.00%> (-3.34%) ⬇️
src/chronos/i18n/sk.ts 85.13% <0.00%> (-1.36%) ⬇️
src/chronos/i18n/cs.ts 87.64% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bb985...065246e. Read the comment docs.

@cypress
Copy link

cypress bot commented May 21, 2021



Test summary

87 0 6 0


Run details

Project ngx-bootstrap
Status Passed
Commit 7b34875 ℹ️
Started Jul 29, 2021 5:42 PM
Ended Jul 29, 2021 5:46 PM
Duration 04:30 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@valorkin valorkin removed the has pr label Jul 16, 2021
@daniloff200 daniloff200 merged commit c0beddb into valor-software:development Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants