fix: don't ship an Ivy compiled library #5915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shipping as Ivy compiled is not recommended by Angular it it breaks every library that has a dependency on ngx-bootstrap and that does not ship as Ivy compiled. Enabling "fullTemplateTypeCheck" also works around an Angular compiler problem regarding the `forRoot()` not working.. See valor-software#5862
|
CI failures seem unrelated.. |
|
Btw. the root cause is not a change in ngx-bootstrap but a change in defaults either in ng-packagr or Angular compiler... |
|
this does make sense, thank you |
daniloff200
approved these changes
Aug 26, 2020
|
I see that the milestone is set for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping as Ivy compiled is not recommended by Angular it it breaks
every library that has a dependency on ngx-bootstrap and that does
not ship as Ivy compiled.
Enabling "fullTemplateTypeCheck" also works around an Angular compiler
problem regarding the
forRoot()not working..See #5862
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.