Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): fix error on blur after init #5760

Conversation

emhaechi
Copy link

Fix error thrown on blur before input is given

Closes #5736

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #5760 into development will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5760      +/-   ##
===============================================
- Coverage        73.72%   73.65%   -0.07%     
===============================================
  Files              323      323              
  Lines            11650    11651       +1     
  Branches          2481     2481              
===============================================
- Hits              8589     8582       -7     
- Misses            1955     1962       +7     
- Partials          1106     1107       +1     
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 81.65% <0.00%> (+1.14%) ⬆️
src/chronos/i18n/it.ts 71.42% <0.00%> (-28.58%) ⬇️
src/chronos/i18n/pt-br.ts 75.00% <0.00%> (-25.00%) ⬇️
...ker/themes/bs/bs-months-calendar-view.component.ts 56.25% <0.00%> (-12.50%) ⬇️
src/chronos/i18n/uk.ts 76.92% <0.00%> (-2.57%) ⬇️
src/datepicker/bs-datepicker.component.ts 68.25% <0.00%> (-1.59%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 74.07% <0.00%> (-1.49%) ⬇️
src/chronos/i18n/cs.ts 84.21% <0.00%> (ø)
src/chronos/i18n/sk.ts 80.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6240fa...55068a9. Read the comment docs.

@ArturKwiatkowski
Copy link

@daniloff200 any chance you could have a look into this? It solves the nasty error which can be observed even on the official docs page. Thanks in advance!

@daniloff200 daniloff200 merged commit 4fc72d6 into valor-software:development May 29, 2020
@ArturKwiatkowski
Copy link

Thanks, how does the release process of this looks now?

@daniel-codrea
Copy link

Any news when this fix will be published?

@szh
Copy link

szh commented Jul 1, 2020

This is in the changelog under 5.7.0, but it's not published to npm. Anything holding it up?

@tomstumshais
Copy link

Hey!
Could someone please publish 5.7.0 version with this fix to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with onBlur in empty Typeahead
6 participants