Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): fix focus after leaving control (#4622) #5593

Merged
merged 7 commits into from
Feb 5, 2020

Conversation

daniloff200
Copy link
Contributor

@daniloff200 daniloff200 commented Jan 11, 2020

Co-authored-by: Dmitriy Danilov daniloff200@gmail.com

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

That's another PR, which related to #4622, cause, fork was deleted, and it need some fixes
closes #1884

src/typeahead/typeahead.directive.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #5593 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5593   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c503b1a...7bc55fe. Read the comment docs.

@daniloff200 daniloff200 changed the title fix(typeahead): fix focus after leaving control (#4622) [WIP] fix(typeahead): fix focus after leaving control (#4622) Jan 17, 2020
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming, please

src/typeahead/typeahead.config.ts Outdated Show resolved Hide resolved
src/typeahead/typeahead.directive.ts Outdated Show resolved Hide resolved
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dmitry-zhemchugov
Copy link
Contributor

Tested this PR. Ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(typeahead): typeahead focus obtained again after leaving the control
4 participants