Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): ability to add services to modal injector #5276

Merged
merged 4 commits into from
Jan 31, 2020

Conversation

rseanhall
Copy link
Contributor

Add providers property to ModalOptions so that services can be added to the injector for the modal.

Closes #5275.

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • [x ] read and followed the CONTRIBUTING.md guide.
  • [ x] built and tested the changes locally.
  • [x ] added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

rseanhall and others added 2 commits June 14, 2019 14:33
Add providers property to ModalOptions so that services can be added to the injector for the modal.

Closes valor-software#5275.
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #5276 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5276   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8270c44...3f94924. Read the comment docs.

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me

@valorkin valorkin merged commit a3fc36d into valor-software:development Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to add services to modal injector
3 participants