Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typeahead): allow optionsListTemplate to access typeahead-container's functions and Demo #5269

Closed
wants to merge 2 commits into from

Conversation

valterkraemer
Copy link

Allow optionsListTemplate to access typeahead-container's functions, things like selectActive() and selectMatch() to make optionsListTemplate useful in more scenarios.

Also includes Demo for optionsListTemplate

Similar PR (stale): #4751
Closes #4036, #3081

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@fhawkes
Copy link

fhawkes commented Aug 17, 2019

@valterkraemer any idea what the ETA for this is. The optionsListTemplate feature is currently useless because you can't actually select any elements since selectMatch isn't exposed.

We are using a ton of typeaheads throughout our app so it isn't really ideal for us to declare a viewchild for each typeahead in the app.

@valterkraemer
Copy link
Author

@fhawkes I have no idea, I followed the contribution guidelines but nobody have reviewed the PR.

@IraErshova
Copy link
Contributor

Close because of duplicate #4751

@IraErshova IraErshova closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeaheads' optionsListTemplate does not provide full component context
4 participants