Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(positioning): fix errors on invalid position #5212

Merged
merged 4 commits into from
May 17, 2019

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented May 15, 2019

With invalid position should set auto position by default

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv May 15, 2019
@ghost ghost added the needs review label May 15, 2019
@Domainv Domainv added this to the 4.3.0 milestone May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #5212 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5212   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9c72e...a1bfd75. Read the comment docs.

@Domainv Domainv changed the title fix(positioning): fix errors on invalid position WIP fix(positioning): fix errors on invalid position May 16, 2019
@Domainv Domainv force-pushed the fix-positioning-invalid-position-error branch from 07362d6 to 3fa805c Compare May 16, 2019 15:31
@ghost ghost added the needs review label May 16, 2019
@Domainv Domainv force-pushed the fix-positioning-invalid-position-error branch from 571143b to 55fcadd Compare May 17, 2019 08:16
@Domainv Domainv removed the WIP label May 17, 2019
@Domainv Domainv changed the title WIP fix(positioning): fix errors on invalid position fix(positioning): fix errors on invalid position May 17, 2019
@ludmilanesvitiy
Copy link
Contributor

Tested in Chrome latest, popover and tooltip, with diff screen resolutions - looks good. Tested with incorrect positions, with correct positions - with and without adaptive positions - all looks well. RFM

@Domainv Domainv merged commit e790196 into development May 17, 2019
@ghost ghost removed the ready for merge label May 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-positioning-invalid-position-error branch May 17, 2019 13:39
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
* fix(positioning): fix errors on invalid position
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
* fix(positioning): fix errors on invalid position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants