-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(positioning): fix errors on invalid position #5212
Conversation
Codecov Report
@@ Coverage Diff @@
## development #5212 +/- ##
============================================
Coverage 51.51% 51.51%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 51 51
Misses 38 38
Partials 10 10 Continue to review full report at Codecov.
|
07362d6
to
3fa805c
Compare
571143b
to
55fcadd
Compare
Tested in Chrome latest, popover and tooltip, with diff screen resolutions - looks good. Tested with incorrect positions, with correct positions - with and without adaptive positions - all looks well. RFM |
* fix(positioning): fix errors on invalid position
* fix(positioning): fix errors on invalid position
With invalid position should set auto position by default
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.