feat(datepicker): Allow to disable specific dates #5046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## development #5046 +/- ##
===============================================
- Coverage 74.78% 74.75% -0.04%
===============================================
Files 281 281
Lines 8547 8563 +16
Branches 1631 1634 +3
===============================================
+ Hits 6392 6401 +9
- Misses 1705 1712 +7
Partials 450 450
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #5046 +/- ##
===============================================
- Coverage 74.85% 74.75% -0.11%
===============================================
Files 281 281
Lines 8547 8571 +24
Branches 1631 1638 +7
===============================================
+ Hits 6398 6407 +9
- Misses 1701 1718 +17
+ Partials 448 446 -2
Continue to review full report at Codecov.
|
| component: require('!!raw-loader?lang=typescript!./demos/disable-dates/disable-dates.ts'), | ||
| html: require('!!raw-loader?lang=markup!./demos/disable-dates/disable-dates.html'), | ||
| description: ` | ||
| Decent description has to come here!!!`, |
There was a problem hiding this comment.
@frederikprijck Could you, please add appropriate description here?
There was a problem hiding this comment.
I've updated the description.
|
@Domainv Anything you want from me before this can get merged? I'd love to resolve it so we can get this merged! |
|
@frederikprijck Needs to add a unit test for the functionality |
Domainv
previously approved these changes
Feb 7, 2019
Domainv
previously approved these changes
Feb 7, 2019
|
Demo tested on latest Chrome, FF - looks good. Code reviewed, looks good. Related links added. |
|
Retested functionality with Daterangepicker demo, checked disabledDates param with inline datepicker, looks good. |
valorkin
approved these changes
Feb 8, 2019
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
* feat(datepicker): Allow to disable specific dates * feat(datepicker): Move isDisabledDate outside of chronos * feat(datepicker): Add datesDisabled to inline datepicker * feat(datepicker): Add datesDisabled to daterangepicker * feat(datepicker): Update demo for datesDisabled * feat(datepicker): Add test for flag days calendar * feat(datepicker): update docs for datesDisabled * feat(datepicker): Fix typo * feat(datepicker): Add demo for datesDisabled with daterangepicker
IraErshova
pushed a commit
to IraErshova/ngx-bootstrap
that referenced
this pull request
Jan 20, 2020
* feat(datepicker): Allow to disable specific dates * feat(datepicker): Move isDisabledDate outside of chronos * feat(datepicker): Add datesDisabled to inline datepicker * feat(datepicker): Add datesDisabled to daterangepicker * feat(datepicker): Update demo for datesDisabled * feat(datepicker): Add test for flag days calendar * feat(datepicker): update docs for datesDisabled * feat(datepicker): Fix typo * feat(datepicker): Add demo for datesDisabled with daterangepicker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
closes #5028
related to #4993
closes #1821