Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): decrease ts version in latest ng #5044

Merged
merged 3 commits into from
Feb 5, 2019

Conversation

ludmilanesvitiy
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #5044 into development will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5044      +/-   ##
===============================================
+ Coverage        74.77%   74.78%   +0.01%     
===============================================
  Files              281      281              
  Lines             8547     8547              
  Branches          1631     1631              
===============================================
+ Hits              6391     6392       +1     
  Misses            1705     1705              
+ Partials           451      450       -1
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 71.79% <0%> (-2.57%) ⬇️
src/chronos/i18n/cs.ts 86.44% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 82.97% <0%> (ø) ⬆️
src/chronos/i18n/it.ts 100% <0%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5008c54...c7035d9. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #5044 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5044   +/-   ##
============================================
  Coverage        74.78%   74.78%           
============================================
  Files              281      281           
  Lines             8547     8547           
  Branches          1631     1631           
============================================
  Hits              6392     6392           
+ Misses            1705     1704    -1     
- Partials           450      451    +1
Impacted Files Coverage Δ
...themes/bs/bs-datepicker-day-decorator.directive.ts 81.81% <0%> (-18.19%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 75.22% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2c151...832048c. Read the comment docs.

Copy link
Contributor

@Domainv Domainv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ludmilanesvitiy With the change, we get the error in schematics tests
screenshot from 2019-02-05 12-37-20

@ghost ghost assigned Domainv Feb 5, 2019
@valorkin valorkin added this to the 3.2.1 milestone Feb 5, 2019
@valorkin valorkin merged commit 0e77f25 into development Feb 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-development-ng-latest branch February 5, 2019 13:40
@ghost ghost removed the needs review label Feb 5, 2019
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
* fix(package): decrease ts version in latest ng

* fix(schematics): add a compatible version of TS also for schematics tests
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
* fix(package): decrease ts version in latest ng

* fix(schematics): add a compatible version of TS also for schematics tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants