refactor(positioning): refactor positioning service #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid memory leaks
… fix tslint errors
ghost
assigned 
Domainv
changed the title
Domainv
commented
Jan 26, 2019
Codecov Report
@@ Coverage Diff @@
## development #5027 +/- ##
===============================================
- Coverage 74.79% 74.31% -0.49%
===============================================
Files 281 312 +31
Lines 8547 8815 +268
Branches 1631 1714 +83
===============================================
+ Hits 6393 6551 +158
- Misses 1703 1767 +64
- Partials 451 497 +46
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #5027 +/- ##
===============================================
- Coverage 74.73% 74.38% -0.36%
===============================================
Files 281 316 +35
Lines 8547 8838 +291
Branches 1631 1725 +94
===============================================
+ Hits 6388 6574 +186
- Misses 1706 1771 +65
- Partials 453 493 +40
Continue to review full report at Codecov.
|
Domainv
changed the title
Domainv
force-pushed
the
refactor-positioning-service
branch
from
e6086c0
to
984fbad
Compare
|
@Domainv , |
|
@Domainv , Also I've found the issue for Safari: |
Domainv
force-pushed
the
refactor-positioning-service
branch
from
51c92cd
to
8cf9fa3
Compare
|
checked after fixing - looks good to me |
Domainv
force-pushed
the
refactor-positioning-service
branch
from
9d87d7c
to
1b63027
Compare
|
@Domainv , |
|
re-checked after last changes: looks good to me |
This was referenced Mar 19, 2019
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
* reafctor(positioning): add popper.js and migrate it to typescript * temporary disable tslint for popper * feat(position): refactored base functionality * update * feat(positioning): flip on overflow added (dirty) * refactor(positioning): add logic of arrow position correcting * refactor(positioning): add shift logic. placement: bottom left/bottom right * refactor(positioning): refactor logic of real-time processing events to avoid memory leaks * refactor(positioning): add types for all methods(minimal solution) && fix tslint errors * refactor(positioning): optimize and fix blur text on tooltip/popover * refactor(positioning): add auto class placement * refactor(positioning): clean up the code * refactor(positioning): unit tests are fixed * refactor(positioning): fix incorrect styles on bootstrap 3 && fix arrow in popovers when auto * refactor(positioning): fix tests for sauce * refactor(positioning): fix typeahead dropup issue * refactor(positioning): fix center for arrow on shift * refactor(positioning): fix tooltip out of screen on mobile * refactor(positioning): refactor modifiers flow * fix(tooltip): back css style Closes valor-software#3303 Closes valor-software#2993 Closes valor-software#4470
IraErshova
pushed a commit
to IraErshova/ngx-bootstrap
that referenced
this pull request
Jan 20, 2020
* reafctor(positioning): add popper.js and migrate it to typescript * temporary disable tslint for popper * feat(position): refactored base functionality * update * feat(positioning): flip on overflow added (dirty) * refactor(positioning): add logic of arrow position correcting * refactor(positioning): add shift logic. placement: bottom left/bottom right * refactor(positioning): refactor logic of real-time processing events to avoid memory leaks * refactor(positioning): add types for all methods(minimal solution) && fix tslint errors * refactor(positioning): optimize and fix blur text on tooltip/popover * refactor(positioning): add auto class placement * refactor(positioning): clean up the code * refactor(positioning): unit tests are fixed * refactor(positioning): fix incorrect styles on bootstrap 3 && fix arrow in popovers when auto * refactor(positioning): fix tests for sauce * refactor(positioning): fix typeahead dropup issue * refactor(positioning): fix center for arrow on shift * refactor(positioning): fix tooltip out of screen on mobile * refactor(positioning): refactor modifiers flow * fix(tooltip): back css style Closes valor-software#3303 Closes valor-software#2993 Closes valor-software#4470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3303
Closes #2993
Closes #4470
Closes #2796
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.