Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add catalan lang #4969

Merged

Conversation

XavisaurusRex
Copy link
Contributor

@XavisaurusRex XavisaurusRex commented Dec 21, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

@ghost ghost added the needs review label Dec 21, 2018
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #4969 into development will decrease coverage by 0.01%.
The diff coverage is 69.56%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4969      +/-   ##
===============================================
- Coverage        74.79%   74.77%   -0.02%     
===============================================
  Files              277      278       +1     
  Lines             8434     8457      +23     
  Branches          1602     1613      +11     
===============================================
+ Hits              6308     6324      +16     
- Misses            1678     1684       +6     
- Partials           448      449       +1
Impacted Files Coverage Δ
src/chronos/public_api.ts 100% <100%> (ø) ⬆️
src/chronos/i18n/ca.ts 68.18% <68.18%> (ø)
src/chronos/i18n/pl.ts 69.23% <0%> (-5.13%) ⬇️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 72.47% <0%> (-1.84%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/chronos/utils/date-getters.ts 81.81% <0%> (+2.27%) ⬆️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️
src/datepicker/engine/flag-days-calendar.ts 81.25% <0%> (+6.25%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe4acc...cbe45f7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #4969 into development will decrease coverage by 0.01%.
The diff coverage is 69.56%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4969      +/-   ##
===============================================
- Coverage        74.79%   74.77%   -0.02%     
===============================================
  Files              277      278       +1     
  Lines             8434     8457      +23     
  Branches          1602     1613      +11     
===============================================
+ Hits              6308     6324      +16     
- Misses            1678     1684       +6     
- Partials           448      449       +1
Impacted Files Coverage Δ
src/chronos/public_api.ts 100% <100%> (ø) ⬆️
src/chronos/i18n/ca.ts 68.18% <68.18%> (ø)
src/chronos/i18n/pl.ts 69.23% <0%> (-5.13%) ⬇️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 72.47% <0%> (-1.84%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/chronos/utils/date-getters.ts 81.81% <0%> (+2.27%) ⬆️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️
src/datepicker/engine/flag-days-calendar.ts 81.25% <0%> (+6.25%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe4acc...cbe45f7. Read the comment docs.

@daniloff200
Copy link
Contributor

closes #4959

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for PR:)

@valorkin valorkin changed the title Feature/add catalan lang feat(datepicker): add catalan lang Dec 30, 2018
@Domainv Domainv added this to the 3.1.5 milestone Jan 8, 2019
@ludmilanesvitiy
Copy link
Contributor

Datepicker Locales demo tested, looks good.

@valorkin
Copy link
Member

Thanks for your time and help!

@valorkin valorkin merged commit 20fadbd into valor-software:development Jan 17, 2019
@ghost ghost removed the ready for merge label Jan 17, 2019
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add language translation for Catalan
5 participants