Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): fix incorrect behavior of nested dropdown (#4739) #4950

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

MilaLysenko
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Closes: #4739

@ghost ghost added the needs review label Dec 18, 2018
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #4950 into development will decrease coverage by 0.04%.
The diff coverage is 47.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4950      +/-   ##
===============================================
- Coverage        74.79%   74.74%   -0.05%     
===============================================
  Files              277      278       +1     
  Lines             8434     8449      +15     
  Branches          1602     1602              
===============================================
+ Hits              6308     6315       +7     
- Misses            1678     1687       +9     
+ Partials           448      447       -1
Impacted Files Coverage Δ
src/dropdown/public_api.ts 100% <100%> (ø) ⬆️
src/dropdown/bs-dropdown.module.ts 93.33% <100%> (+0.47%) ⬆️
src/dropdown/bs-dropdown-nested.directive.ts 35.71% <35.71%> (ø)
src/chronos/i18n/pl.ts 71.79% <0%> (-2.57%) ⬇️
src/chronos/i18n/cs.ts 86.44% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 82.97% <0%> (ø) ⬆️
src/chronos/i18n/it.ts 100% <0%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe4acc...478f360. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #4950 into development will increase coverage by 0.02%.
The diff coverage is 47.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4950      +/-   ##
===============================================
+ Coverage        74.71%   74.74%   +0.02%     
===============================================
  Files              276      278       +2     
  Lines             8385     8449      +64     
  Branches          1594     1602       +8     
===============================================
+ Hits              6265     6315      +50     
- Misses            1677     1687      +10     
- Partials           443      447       +4     
Impacted Files Coverage Δ
src/dropdown/bs-dropdown-nested.directive.ts 35.71% <35.71%> (ø)
src/dropdown/bs-dropdown.module.ts 93.33% <100.00%> (+0.47%) ⬆️
src/dropdown/public_api.ts 100.00% <100.00%> (ø)
src/utils/warn-once.ts 50.00% <0.00%> (-50.00%) ⬇️
...themes/bs/bs-datepicker-day-decorator.directive.ts 81.81% <0.00%> (-18.19%) ⬇️
src/utils/triggers.ts 66.19% <0.00%> (-3.81%) ⬇️
src/chronos/i18n/pl.ts 71.79% <0.00%> (-2.57%) ⬇️
...c/datepicker/bs-daterangepicker-input.directive.ts 24.41% <0.00%> (-1.20%) ⬇️
src/datepicker/bs-datepicker-input.directive.ts 45.20% <0.00%> (-0.63%) ⬇️
src/chronos/i18n/cs.ts 86.44% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4dd89...478f360. Read the comment docs.

@valorkin
Copy link
Member

We should pair review this one

@higurush
Copy link

higurush commented Jul 25, 2019

This one works quite well. However, a little suggestion though, is to implement some kind of a timer, since with a long, page sized menu, the submenu instantly disappears.
And if you implement the timer itself, you can see that the menus are still overlapping each other.

Another improvement could be to place the submenus where the parent option is, instead of just top:0

this.renderer.setStyle(nestedMenu , 'top', this.elem.nativeElement.offsetTop + 'px');

@Domainv Domainv changed the title fix(dropdown): fix uncorrect behavior of nested dropdown (#4739) fix(dropdown): fix incorrect behavior of nested dropdown (#4739) Oct 1, 2019
@deltaGPhys
Copy link

Is anoybody monitoring this PR? This bug makes the library useless for many.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown nested has issue and not to be resolve
5 participants