-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): fix incorrect behavior of nested dropdown (#4739) #4950
base: development
Are you sure you want to change the base?
fix(dropdown): fix incorrect behavior of nested dropdown (#4739) #4950
Conversation
Codecov Report
@@ Coverage Diff @@
## development #4950 +/- ##
===============================================
- Coverage 74.79% 74.74% -0.05%
===============================================
Files 277 278 +1
Lines 8434 8449 +15
Branches 1602 1602
===============================================
+ Hits 6308 6315 +7
- Misses 1678 1687 +9
+ Partials 448 447 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #4950 +/- ##
===============================================
+ Coverage 74.71% 74.74% +0.02%
===============================================
Files 276 278 +2
Lines 8385 8449 +64
Branches 1594 1602 +8
===============================================
+ Hits 6265 6315 +50
- Misses 1677 1687 +10
- Partials 443 447 +4
Continue to review full report at Codecov.
|
We should pair review this one |
This one works quite well. However, a little suggestion though, is to implement some kind of a timer, since with a long, page sized menu, the submenu instantly disappears. Another improvement could be to place the submenus where the parent option is, instead of just
|
Is anoybody monitoring this PR? This bug makes the library useless for many. |
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
Closes: #4739