Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): reverse of docs list #4912

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Dec 7, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Dec 7, 2018
@ghost ghost added the needs review label Dec 7, 2018
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #4912 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4912      +/-   ##
===============================================
- Coverage         74.7%   74.68%   -0.03%     
===============================================
  Files              276      276              
  Lines             8385     8385              
  Branches          1594     1594              
===============================================
- Hits              6264     6262       -2     
- Misses            1680     1686       +6     
+ Partials           441      437       -4
Impacted Files Coverage Δ
src/datepicker/reducer/bs-datepicker.effects.ts 72.47% <0%> (-1.84%) ⬇️
src/typeahead/typeahead.directive.ts 73.82% <0%> (-1.05%) ⬇️
src/datepicker/engine/flag-days-calendar.ts 80% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a582eb7...f44edbc. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #4912 into development will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4912      +/-   ##
===============================================
- Coverage        74.71%   74.65%   -0.06%     
===============================================
  Files              276      276              
  Lines             8385     8385              
  Branches          1594     1594              
===============================================
- Hits              6265     6260       -5     
- Misses            1677     1684       +7     
+ Partials           443      441       -2
Impacted Files Coverage Δ
src/utils/triggers.ts 65% <0%> (-5%) ⬇️
src/chronos/i18n/pl.ts 71.79% <0%> (-2.57%) ⬇️
src/component-loader/component-loader.class.ts 74.1% <0%> (-2.16%) ⬇️
src/chronos/i18n/cs.ts 86.44% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 82.97% <0%> (ø) ⬆️
src/chronos/i18n/it.ts 100% <0%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4dd89...f7073e0. Read the comment docs.

@valorkin valorkin added this to the 3.1.4 milestone Dec 8, 2018
valorkin
valorkin previously approved these changes Dec 8, 2018
@ludmilanesvitiy
Copy link
Contributor

In this case, current version will be latest in the list. I think, will be better to move Current to the top of the list.
screenshot from 2018-12-10 11-51-51

@ludmilanesvitiy
Copy link
Contributor

Tested, looks good.

@valorkin valorkin merged commit f17459f into development Dec 12, 2018
@ghost ghost removed the ready for merge label Dec 12, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-docs-list-reverse branch December 12, 2018 08:44
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants