Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): fix component option #4892

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Dec 5, 2018

Closes #4888

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Dec 5, 2018
@ghost ghost added the needs review label Dec 5, 2018
@Domainv Domainv added this to the 3.1.3 milestone Dec 5, 2018
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #4892 into development will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4892      +/-   ##
===============================================
- Coverage         74.7%   74.62%   -0.08%     
===============================================
  Files              273      273              
  Lines             8336     8336              
  Branches          1588     1588              
===============================================
- Hits              6227     6221       -6     
- Misses            1671     1680       +9     
+ Partials           438      435       -3
Impacted Files Coverage Δ
src/utils/triggers.ts 65% <0%> (-5%) ⬇️
src/component-loader/component-loader.class.ts 74.1% <0%> (-2.16%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 73.58% <0%> (-1.89%) ⬇️
src/datepicker/engine/flag-days-calendar.ts 80% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9671c7e...ebd54fd. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #4892 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development   #4892   +/-   ##
===========================================
  Coverage         74.7%   74.7%           
===========================================
  Files              273     273           
  Lines             8336    8336           
  Branches          1588    1588           
===========================================
  Hits              6227    6227           
  Misses            1671    1671           
  Partials           438     438

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9671c7e...ea88b06. Read the comment docs.

@valorkin valorkin merged commit 6cc0ce6 into development Dec 5, 2018
@ghost ghost removed the ready for tests label Dec 5, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-schematics-component branch December 5, 2018 20:44
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants