Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add strict mode support #4869

Merged
merged 6 commits into from
Dec 5, 2018
Merged

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Dec 3, 2018

Closes #4848

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Dec 3, 2018
@ghost ghost added the needs review label Dec 3, 2018
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #4869 into development will decrease coverage by 1.22%.
The diff coverage is 75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4869      +/-   ##
===============================================
- Coverage        75.66%   74.43%   -1.23%     
===============================================
  Files              237      273      +36     
  Lines             7336     8321     +985     
  Branches          1464     1582     +118     
===============================================
+ Hits              5551     6194     +643     
- Misses            1379     1694     +315     
- Partials           406      433      +27
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 74.86% <ø> (+1.04%) ⬆️
src/rating/rating.component.ts 76.66% <ø> (ø) ⬆️
src/utils/facade/browser.ts 76.92% <75%> (ø) ⬆️
src/chronos/i18n/pl.ts 72.22% <0%> (-2.78%) ⬇️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
...c/datepicker/bs-daterangepicker-input.directive.ts 25.6% <0%> (ø)
src/datepicker/engine/flag-years-calendar.ts 15% <0%> (ø)
src/datepicker/reducer/bs-datepicker.reducer.ts 43.33% <0%> (ø)
src/datepicker/utils/matrix-utils.ts 100% <0%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bd459...056c3b5. Read the comment docs.

@valorkin valorkin added this to the 3.1.3 milestone Dec 3, 2018
@valorkin valorkin merged commit 58d4517 into development Dec 5, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-add-strict-support branch December 5, 2018 18:47
@ghost ghost removed the ready for merge label Dec 5, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants