-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): add strict mode support #4869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Domainv
Dec 3, 2018
ghost
added
the
needs review
label
Dec 3, 2018
Domainv
force-pushed
the
feat-add-strict-support
branch
from
December 3, 2018 11:26
3b36397
to
87f4011
Compare
Codecov Report
@@ Coverage Diff @@
## development #4869 +/- ##
===============================================
- Coverage 75.66% 74.43% -1.23%
===============================================
Files 237 273 +36
Lines 7336 8321 +985
Branches 1464 1582 +118
===============================================
+ Hits 5551 6194 +643
- Misses 1379 1694 +315
- Partials 406 433 +27
Continue to review full report at Codecov.
|
valorkin
approved these changes
Dec 5, 2018
ghost
removed
the
ready for merge
label
Dec 5, 2018
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4848
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.