Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): adding schematic for ng-add #4678

Merged
merged 2 commits into from
Oct 17, 2018

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Oct 9, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@Domainv Domainv added the WIP label Oct 9, 2018
@ghost ghost assigned Domainv Oct 9, 2018
@ghost ghost added the needs review label Oct 9, 2018
@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@90765c9). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #4678   +/-   ##
==============================================
  Coverage               ?   74.35%           
==============================================
  Files                  ?      202           
  Lines                  ?     7101           
  Branches               ?     1446           
==============================================
  Hits                   ?     5280           
  Misses                 ?     1425           
  Partials               ?      396
Impacted Files Coverage Δ
scripts/test.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90765c9...def1715. Read the comment docs.

@Domainv Domainv force-pushed the feat-ng-add-schematic branch 3 times, most recently from ff6759d to dfccfe4 Compare October 10, 2018 15:33
@Domainv Domainv changed the title WIP feat(schematics): adding schematic for ng-add feat(schematics): adding schematic for ng-add Oct 10, 2018
@Domainv Domainv removed the WIP label Oct 10, 2018
@Domainv Domainv force-pushed the feat-build-with-packagr branch 3 times, most recently from a49808a to 1b59ca0 Compare October 11, 2018 14:58
@Domainv Domainv force-pushed the feat-ng-add-schematic branch 2 times, most recently from ebe06cd to 02b2098 Compare October 12, 2018 11:56
@Domainv Domainv changed the base branch from feat-build-with-packagr to development October 15, 2018 15:15
@Domainv Domainv force-pushed the feat-ng-add-schematic branch 4 times, most recently from 2ccfb3d to 05fd409 Compare October 15, 2018 16:06
@ludmilanesvitiy
Copy link
Contributor

ludmilanesvitiy commented Oct 16, 2018

Tested "ng add ngx-bootstrap" functionality locally with verdaccio and new project (ng new) - looks good.

@valorkin valorkin merged commit 67b88f5 into development Oct 17, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-ng-add-schematic branch October 17, 2018 09:45
@ghost ghost removed the ready for merge label Oct 17, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
* feat(schematics): adding 'ng add'

* feat(schematics): clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants