Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix browser rounding width/height bug in ng-position #4328

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

webdevan
Copy link
Contributor

Potential fix for #4322.

Sorry for not reading the contribution guidelines and following the correct procedure, but I would appreciate if someone can review this and perhaps if they understand how ng-positioning.js works better than I do then they can submit a fix based on this?

@ghost ghost added the needs review label May 11, 2018
@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #4328 into development will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4328      +/-   ##
===============================================
+ Coverage        71.89%   71.91%   +0.02%     
===============================================
  Files              258      258              
  Lines             8383     8383              
  Branches          1648     1648              
===============================================
+ Hits              6027     6029       +2     
+ Misses            1900     1899       -1     
+ Partials           456      455       -1
Impacted Files Coverage Δ
src/positioning/ng-positioning.ts 73.91% <100%> (ø) ⬆️
src/sortable/sortable.component.ts 100% <0%> (ø) ⬆️
src/pagination/pagination.component.ts 85.82% <0%> (ø) ⬆️
src/chronos/i18n/pl.ts 77.77% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9fda6...25fbf92. Read the comment docs.

@webdevan
Copy link
Contributor Author

Hi, just wondering what the release schedule is like and whether this will go into a 2.0.6 release or 3.0.x or both?

@valorkin valorkin merged commit 4201a30 into valor-software:development Jun 19, 2018
@ghost ghost removed the ready for tests label Jun 19, 2018
@valorkin
Copy link
Member

Thanks for PR :)

leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants