Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add Romanian locale to date picker #4205

Merged
merged 11 commits into from
Apr 24, 2018

Conversation

5earle
Copy link
Contributor

@5earle 5earle commented Apr 8, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@5earle
Copy link
Contributor Author

5earle commented Apr 8, 2018

Addresses #4158

Copy link

@mrjohnr mrjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@valorkin valorkin changed the title add Romanian locale to date picker feat(datepicker): add Romanian locale to date picker Apr 13, 2018
@ghost ghost assigned valorkin Apr 13, 2018
@valorkin valorkin merged commit 6a95b76 into valor-software:development Apr 24, 2018
@ghost ghost removed the ready for tests label Apr 24, 2018
@valorkin
Copy link
Member

thanks for PR!

sorry for the delay, was busy organizing https://ngtalks.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants