Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): Mongolian locale #4161

Merged
merged 2 commits into from
Apr 25, 2018

Conversation

javkhaanj7
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #4161 into development will decrease coverage by <.01%.
The diff coverage is 85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4161      +/-   ##
===============================================
- Coverage        72.24%   72.23%   -0.01%     
===============================================
  Files              256      254       -2     
  Lines             8293     8258      -35     
  Branches          1589     1575      -14     
===============================================
- Hits              5991     5965      -26     
+ Misses            1873     1867       -6     
+ Partials           429      426       -3
Impacted Files Coverage Δ
src/locale.ts 100% <100%> (ø) ⬆️
src/chronos/i18n/mn.ts 84.21% <84.21%> (ø)
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/uk.ts 78.04% <0%> (-2.44%) ⬇️
demo/src/app/docs/api-docs/analytics/analytics.ts 36.36% <0%> (-1.74%) ⬇️
...hemes/bs/bs-daterangepicker-container.component.ts 30.76% <0%> (ø) ⬆️
demo/src/app/app.component.ts 34.28% <0%> (ø) ⬆️
...ker/themes/bs/bs-datepicker-container.component.ts 38.7% <0%> (ø) ⬆️
src/dropdown/bs-dropdown.directive.ts 74.01% <0%> (ø) ⬆️
src/chronos/i18n/pl.ts 72.22% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e3f56...3548b4f. Read the comment docs.

valorkin
valorkin previously approved these changes Apr 25, 2018
@valorkin
Copy link
Member

thanks for your PR!
sorry for a delay, I was organizing https://ngtalks.io

@valorkin valorkin merged commit 91ffd36 into valor-software:development Apr 25, 2018
@ghost ghost removed the needs review label Apr 25, 2018
@javkhaanj7
Copy link
Contributor Author

Thank you. Good luck on your NgTalks conference.

@valorkin
Copy link
Member

@javkhaanj7 thanks, I will be merging more PRs this and next week

@valorkin
Copy link
Member

new version should be tested and published next Friday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants