Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change function name from hightlight to highlight #4091

Merged
merged 1 commit into from
May 15, 2018

Conversation

5earle
Copy link
Contributor

@5earle 5earle commented Mar 24, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@5earle
Copy link
Contributor Author

5earle commented Mar 24, 2018

Addresses #3518

@codecov
Copy link

codecov bot commented Mar 24, 2018

Codecov Report

Merging #4091 into development will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4091      +/-   ##
===============================================
- Coverage        72.23%   72.19%   -0.04%     
===============================================
  Files              252      252              
  Lines             8237     8237              
  Branches          1565     1565              
===============================================
- Hits              5950     5947       -3     
- Misses            1866     1868       +2     
- Partials           421      422       +1
Impacted Files Coverage Δ
src/typeahead/typeahead-container.component.ts 82.11% <100%> (ø) ⬆️
src/chronos/i18n/pl.ts 69.44% <0%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a384d9...bbbde23. Read the comment docs.

@valorkin
Copy link
Member

I never was able to pronounce this word correctly :)

@valorkin valorkin merged commit 97171ff into valor-software:development May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants