docs(buttons): add aria-attributes #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #4082 +/- ##
============================================
Coverage 72.29% 72.29%
============================================
Files 254 254
Lines 8266 8266
Branches 1579 1579
============================================
Hits 5976 5976
Misses 1868 1868
Partials 422 422
Continue to review full report at Codecov.
|
ghost
assigned 
IlyaSurmay
suggested changes
Mar 30, 2018
| @@ -26,11 +26,13 @@ export const CHECKBOX_CONTROL_VALUE_ACCESSOR: any = { | |||
| }) | |||
| export class ButtonCheckboxDirective implements ControlValueAccessor, OnInit { | |||
| /** Truthy value, will be set to ngModel */ | |||
| @Input() btnCheckboxTrue: any = true; | |||
| @Input() btnCheckboxTrue = true; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| <button type="button" class="btn btn-primary" [disabled]="disabled">Button</button> | ||
| <button type="button" class="btn btn-warning" (click)="disabled = !disabled">Enable/Disable</button> | ||
| <button type="button" class="btn btn-primary" [disabled]="disabled" [attr.aria-disabled]="disabled">Button</button> | ||
| <button type="button" class="btn btn-warning" (click)="isDisabled()" [attr.aria-pressed]="isPressed">Enable/Disable</button> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
IlyaSurmay
suggested changes
Apr 4, 2018
| @@ -1,9 +0,0 @@ | |||
| import { Component } from '@angular/core'; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
IlyaSurmay
approved these changes
Apr 5, 2018
|
Not all described in linked issue aria-attributes were added (aria-disabled wasn't) |
valorkin
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4068
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.