fix(typeahead): Clicking an item does not raise the typeaheadOnSelectevent #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,8 @@ const TEMPLATE:any = { | |||
| [Ng2BootstrapTheme.BS4]: ` | |||
| <div class="dropdown-menu" | |||
| [ngStyle]="{top: top, left: left, display: display}" | |||
| style="display: block"> | |||
| style="display: block" | |||
| (mouseleave)="hideMenu()"> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Please also see my PR #395. I keep the blur handling, and fixed the mouseclick handling by listening to the mousedown event instead click event. This this will also hide the popup for keyboard-only users (which will not work with this PR afaik). |
|
#395 fixes the problem |
|
Fixed using a different approach #398. Which one makes more sense ? |
|
I like your approach even more than mine :) |
valorkin
pushed a commit
that referenced
this pull request
Apr 12, 2016
|
Thanks for PR, closed in favor of #398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #363