Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(datepicker): decompose Basic demo (remove presetting dates for d… #3673

Merged
merged 4 commits into from
Feb 22, 2018
Merged

docs(datepicker): decompose Basic demo (remove presetting dates for d… #3673

merged 4 commits into from
Feb 22, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 5, 2018 •
edited by ghost
Loading

1.remove presetting dates for datepicker and daterangepicker (basic section) http://joxi.ru/4AkgoOwtMpRdeA
2. add new section : Initial state of a date, which set using bsValue, [(ngModel)] http://joxi.ru/Vm6ZxbeHxl7wqm
related to #3669

@codecov
Copy link

codecov bot commented Feb 7, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (development@f6bbb3d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #3673   +/-   ##
==============================================
  Coverage               ?   72.03%           
==============================================
  Files                  ?      252           
  Lines                  ?     8159           
  Branches               ?     1552           
==============================================
  Hits                   ?     5877           
  Misses                 ?     1859           
  Partials               ?      423

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bbb3d...eb0fd80. Read the comment docs.

@ghost ghost force-pushed the docs-decompose-datepicker-basic branch from c272f6a to cd96d65 Compare February 8, 2018 13:22
IlyaSurmay
IlyaSurmay suggested changes Feb 8, 2018
View reviewed changes
demo/src/app/components/+datepicker/demos/date-initial-state/date-initial-state.ts Outdated
})
export class DemoDatepickerDateInitialStateComponent {
bsValue: Date = new Date();
bsRangeValue: any = [new Date(2017, 7, 4), new Date(2017, 7, 20)];

This comment was marked as off-topic.

Sign in to view

demo/src/app/components/+datepicker/datepicker-section.list.ts Outdated
outlet: DemoDatepickerBasicComponent
},
{
title: 'Initial state of a date',

This comment was marked as off-topic.

Sign in to view

@ghost ghost force-pushed the docs-decompose-datepicker-basic branch from cd96d65 to 357f390 Compare February 8, 2018 15:04
IlyaSurmay
IlyaSurmay previously approved these changes Feb 8, 2018
View reviewed changes
@ghost ghost assigned IlyaSurmay Feb 8, 2018
@ghost ghost added the in progress label Feb 8, 2018
@ghost ghost force-pushed the docs-decompose-datepicker-basic branch from b69493a to df316bd Compare February 9, 2018 11:30
@ghost ghost force-pushed the docs-decompose-datepicker-basic branch 2 times, most recently from 0cfd4c5 to e3162cb Compare February 12, 2018 07:18
@ghost
Copy link
Author

ghost commented Feb 12, 2018

update and testing my branch according to Yevheniia comments(conflicts in files) which I can't see

@ghost ghost force-pushed the docs-decompose-datepicker-basic branch 2 times, most recently from a58d632 to 0adc5eb Compare February 12, 2018 10:26
IlyaSurmay
IlyaSurmay suggested changes Feb 13, 2018
View reviewed changes
demo/src/app/components/+datepicker/demos/date-initial-state/date-initial-state.ts Outdated
templateUrl: './date-initial-state.html'
})
export class DemoDatepickerDateInitialStateComponent {
bsValue: Date = new Date();

This comment was marked as off-topic.

Sign in to view

demo/src/app/components/+datepicker/demos/date-initial-state/date-initial-state.ts Outdated
export class DemoDatepickerDateInitialStateComponent {
bsValue: Date = new Date();
bsRangeValue: Date[];
maxDate: Date = new Date();

This comment was marked as off-topic.

Sign in to view

@ghost ghost force-pushed the docs-decompose-datepicker-basic branch from 0adc5eb to 24d9384 Compare February 13, 2018 14:55
IlyaSurmay
IlyaSurmay previously approved these changes Feb 13, 2018
View reviewed changes
@YevheniiaMazur
Copy link

Tested, looks good

valorkin
valorkin previously approved these changes Feb 22, 2018
View reviewed changes
@valorkin valorkin dismissed stale reviews from IlyaSurmay and themself via eb0fd80 February 22, 2018 14:38
@ghost ghost assigned valorkin Feb 22, 2018
@valorkin valorkin merged commit 879adb7 into valor-software:development Feb 22, 2018
@ghost ghost removed the ready for merge label Feb 22, 2018
@EvilAlexei EvilAlexei mentioned this pull request Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@valorkin valorkin

@IlyaSurmay IlyaSurmay

Labels
comp(docs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YevheniiaMazur @valorkin @IlyaSurmay