Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(datepicker): add demo for isOpen state #3647

Merged
merged 2 commits into from Feb 22, 2018
Merged

docs(datepicker): add demo for isOpen state #3647

merged 2 commits into from Feb 22, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2018

add demo for isOpen state(when browser window is open the datepicker should be open) #3640

@@ -0,0 +1,5 @@
<div class="row">
<div class="col-xs-12 col-12 col-md-4 form-group">
<input class="form-control" placeholder="Please choose a date" bsDatepicker [isOpen]="isOpen"/>

This comment was marked as off-topic.

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@7d10900). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #3647   +/-   ##
==============================================
  Coverage               ?   72.05%           
==============================================
  Files                  ?      252           
  Lines                  ?     8159           
  Branches               ?     1552           
==============================================
  Hits                   ?     5879           
  Misses                 ?     1858           
  Partials               ?      422

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d10900...d521b7d. Read the comment docs.

<input class="form-control" placeholder="Please choose a date" #dp="bsDatepicker" bsDatepicker [isOpen]="isOpen"/>
</div>
<div class="col-xs-4 col-4 col-md-4 form-group">
<input class="btn btn-success" type="button" value="Toggle" (click)="dp.toggle()">

This comment was marked as off-topic.

IlyaSurmay
IlyaSurmay previously approved these changes Feb 6, 2018
@YevheniiaMazur
Copy link

Needs to fix conflicting files (update your branch from latest development and solve conflicts)

IlyaSurmay
IlyaSurmay previously approved these changes Feb 7, 2018
@YevheniiaMazur
Copy link

Needs to fix local conflicts (steps to reproduce - pull pr and update it using same commands as on screenshot)
localmergeconflict

@ghost
Copy link
Author

ghost commented Feb 9, 2018

update and testing my branch according to Yevheniia comments(conflicts in files) which I can't see

IlyaSurmay
IlyaSurmay previously approved these changes Feb 13, 2018
@YevheniiaMazur
Copy link

Tested, looks good

@ghost ghost assigned valorkin Feb 22, 2018
@valorkin valorkin merged commit 697dc87 into valor-software:development Feb 22, 2018
@ghost ghost removed the ready for merge label Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants