Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chronos): bs-moment renamed to chronos and all locales was suffixed with Locale #3456

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

valorkin
Copy link
Member

BREAKING CHANGE:

  • bs-moment renamed to chronos
  • all locales was suffixed with Locale (en -> enLocale)

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

…xed with Locale

BREAKING CHANGE:
- bs-moment renamed to chronos
- all locales was suffixed with Locale (en -> enLocale)
@ghost ghost assigned valorkin Jan 15, 2018
@ghost ghost added the in progress label Jan 15, 2018
@codecov
Copy link

codecov bot commented Jan 15, 2018

Codecov Report

Merging #3456 into development will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3456      +/-   ##
===============================================
- Coverage        72.47%   72.33%   -0.15%     
===============================================
  Files              249      249              
  Lines             8062     8039      -23     
  Branches          1527     1527              
===============================================
- Hits              5843     5815      -28     
- Misses            1795     1797       +2     
- Partials           424      427       +3
Impacted Files Coverage Δ
src/chronos/utils.ts 100% <ø> (ø)
src/chronos/format.ts 87.09% <ø> (ø)
src/chronos/utils/type-checks.ts 86.48% <ø> (ø)
src/chronos/utils/date-compare.ts 82.85% <ø> (ø)
src/chronos/duration/create.ts 75% <ø> (ø)
src/chronos/locale/locale.class.ts 57.35% <ø> (ø)
src/chronos/locale/locale.defaults.ts 100% <ø> (ø)
src/chronos/parse/token.ts 95.23% <ø> (ø)
src/chronos/utils/compare-arrays.ts 88.88% <ø> (ø)
src/chronos/create/valid.ts 90% <ø> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6b119...80ad328. Read the comment docs.

@valorkin valorkin merged commit dfd489b into development Jan 15, 2018
@ghost ghost removed the in progress label Jan 15, 2018
@valorkin valorkin deleted the feat-chronos-rename branch January 15, 2018 13:21
@valorkin valorkin added this to the v2.0.0-rc.2 milestone Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant