Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): date manipulation was jumping over a month top #3130

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

valorkin
Copy link
Member

fixes #2902

@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #3130 into development will decrease coverage by 0.05%.
The diff coverage is 16.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3130      +/-   ##
===============================================
- Coverage        65.23%   65.18%   -0.06%     
===============================================
  Files              209      209              
  Lines             5635     5641       +6     
  Branches           993      994       +1     
===============================================
+ Hits              3676     3677       +1     
- Misses            1696     1701       +5     
  Partials           263      263
Impacted Files Coverage Δ
src/bs-moment/utils/date-setters.ts 40.9% <16.66%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bf18e...dc1b849. Read the comment docs.

@YevheniiaMazur
Copy link

tested, looks good

@valorkin valorkin merged commit a7416e6 into development Nov 28, 2017
@ghost ghost removed the ready for merge label Nov 28, 2017
@valorkin valorkin deleted the fix-bsmoment-date-manipulation branch November 28, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Range Picker not showing the correct months when reopen the range popup
2 participants