Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): model should be prestine on init from ngModel #3115

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

valorkin
Copy link
Member

fixes #3014

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #3115 into development will decrease coverage by 0.12%.
The diff coverage is 7.69%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3115      +/-   ##
===============================================
- Coverage        65.44%   65.31%   -0.13%     
===============================================
  Files              209      209              
  Lines             5617     5628      +11     
  Branches           988      990       +2     
===============================================
  Hits              3676     3676              
- Misses            1678     1689      +11     
  Partials           263      263
Impacted Files Coverage Δ
...c/datepicker/bs-daterangepicker-input.directive.ts 26.66% <0%> (-2.43%) ⬇️
src/datepicker/bs-datepicker-input.directive.ts 29.09% <14.28%> (-3.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec445e2...68df7fa. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 6bb077c into development Nov 27, 2017
@valorkin valorkin deleted the fix-datepicker-pristine-model branch November 27, 2017 16:18
@ghost ghost removed the ready for merge label Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker input is always dirty when ngModel is a non-null value
2 participants