Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): bootstrap 4 dropup fix in IE11 #3057

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

brgaulin
Copy link
Contributor

The inline style on the element is top: auto, this fix is for cross browser support.

Fixes #3054

The inline style on the element is top: auto, this fix is for cross browser support.

Fixes valor-software#3054
@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #3057 into development will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3057      +/-   ##
===============================================
+ Coverage        65.49%   65.52%   +0.02%     
===============================================
  Files              207      207              
  Lines             5597     5595       -2     
  Branches           985      984       -1     
===============================================
  Hits              3666     3666              
+ Misses            1669     1667       -2     
  Partials           262      262
Impacted Files Coverage Δ
src/dropdown/bs-dropdown.directive.ts 72.95% <0%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97211b...66afff4. Read the comment docs.

@valorkin
Copy link
Member

@EvilAlexei please review
@YevheniiaMazur please test

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 632abe1 into valor-software:development Nov 23, 2017
@valorkin
Copy link
Member

Thanks for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropup does not work in IE11 / BS4
3 participants