Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): change import for barrel file's, update seed doc #2990

Merged
merged 4 commits into from
Jan 11, 2018

Conversation

nouc23
Copy link
Contributor

@nouc23 nouc23 commented Nov 7, 2017

fixes #1912

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #2990 into development will decrease coverage by 1.03%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2990      +/-   ##
===============================================
- Coverage        65.03%   63.99%   -1.04%     
===============================================
  Files              210      207       -3     
  Lines             5691     5597      -94     
  Branches          1000      985      -15     
===============================================
- Hits              3701     3582     -119     
+ Misses            1724     1669      -55     
- Partials           266      346      +80
Impacted Files Coverage Δ
src/component-loader/component-loader.class.ts 74.5% <ø> (-0.33%) ⬇️
src/modal/modal.module.ts 90.9% <100%> (ø) ⬆️
src/tooltip/tooltip.directive.ts 56.7% <100%> (-4.13%) ⬇️
src/popover/popover.module.ts 100% <100%> (ø) ⬆️
src/index.ts 100% <100%> (ø) ⬆️
src/dropdown/bs-dropdown.module.ts 92.85% <100%> (ø) ⬆️
src/component-loader/component-loader.factory.ts 66.66% <100%> (-33.34%) ⬇️
src/progressbar/progressbar.component.ts 93.75% <100%> (ø) ⬆️
src/popover/popover.directive.ts 78.57% <100%> (-3.58%) ⬇️
src/tooltip/tooltip.module.ts 100% <100%> (ø) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad82bb...683ae28. Read the comment docs.

@nouc23 nouc23 closed this Nov 8, 2017
@nouc23 nouc23 reopened this Nov 8, 2017
@IlyaSurmay IlyaSurmay changed the title change import for barrel file's feat(build): change import for barrel file's, update seed doc Nov 15, 2017
@valorkin
Copy link
Member

FYI we found couple more issues with systemjs, fixing...

@ghost ghost assigned valorkin Jan 5, 2018
@ghost ghost added the in progress label Jan 5, 2018
@valorkin
Copy link
Member

valorkin commented Jan 5, 2018

@IlyaSurmay how to make angular-cli fail on build if imported not from index file
?disable node module resolution?

@valorkin valorkin merged commit 7346a5a into valor-software:development Jan 11, 2018
@ghost ghost removed the in progress label Jan 11, 2018
@valorkin
Copy link
Member

thanks for contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(system.js): Unable to build AoT with ModalModule on System.js
3 participants