-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datepicker): added Hebrew locale support for datepicker #2904
Conversation
Codecov Report
@@ Coverage Diff @@
## development #2904 +/- ##
==============================================
- Coverage 70.73% 70.7% -0.03%
==============================================
Files 137 137
Lines 4169 4165 -4
Branches 739 737 -2
==============================================
- Hits 2949 2945 -4
Misses 914 914
Partials 306 306
Continue to review full report at Codecov.
|
@msarsha hey, thanks for the contribution! |
@msarsha maybe you want to add it as an option to demo page? |
If there are other sections in the demo it should be added to, let me know, I will add it. |
@msarsha awesome, thanks. QA will be available on vacation till monday, when she will gave approve we will merge and release it, ok? |
Tested, looks good. Needs to resolve conflicting file |
@msarsha , I ment this merge conflict in file demo-datepicker.module.ts: |
@msarsha hey, thanks a lot for the contribution! |
thanks again :) |
Hey,
Added Hebrew locale (#2769).