Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): added Hebrew locale support for datepicker #2904

Merged
merged 3 commits into from
Nov 21, 2017

Conversation

msarsha
Copy link
Contributor

@msarsha msarsha commented Oct 24, 2017

Hey,

Added Hebrew locale (#2769).

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Oct 24, 2017

Codecov Report

Merging #2904 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #2904      +/-   ##
==============================================
- Coverage        70.73%   70.7%   -0.03%     
==============================================
  Files              137     137              
  Lines             4169    4165       -4     
  Branches           739     737       -2     
==============================================
- Hits              2949    2945       -4     
  Misses             914     914              
  Partials           306     306
Impacted Files Coverage Δ
src/timepicker/timepicker.utils.ts 92.5% <0%> (-1.25%) ⬇️
src/timepicker/timepicker.component.ts 91.42% <0%> (-0.09%) ⬇️
src/typeahead/typeahead.directive.ts 70.68% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32cbbc...980baa0. Read the comment docs.

@valorkin
Copy link
Member

@msarsha hey, thanks for the contribution!
but please, remove package-lock

@valorkin
Copy link
Member

@msarsha maybe you want to add it as an option to demo page?

@msarsha
Copy link
Contributor Author

msarsha commented Oct 25, 2017

@valorkin

I did add it.

If there are other sections in the demo it should be added to, let me know, I will add it.

@valorkin
Copy link
Member

@msarsha awesome, thanks. QA will be available on vacation till monday, when she will gave approve we will merge and release it, ok?

@YevheniiaMazur
Copy link

Tested, looks good. Needs to resolve conflicting file

@YevheniiaMazur
Copy link

@msarsha , I ment this merge conflict in file demo-datepicker.module.ts:
conflictingfile

@valorkin
Copy link
Member

valorkin commented Nov 3, 2017

@msarsha hey, thanks a lot for the contribution!
if you can merge tests for locale too, it would be awesome!

@valorkin valorkin merged commit f2d5156 into valor-software:development Nov 21, 2017
@valorkin
Copy link
Member

thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants