Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): fix undefined container class #2283

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

IlyaSurmay
Copy link
Contributor

Fixes issue with undefined in class list

@IlyaSurmay IlyaSurmay requested a review from valorkin July 26, 2017 11:32
@valorkin valorkin added this to the v1.8.1 milestone Jul 26, 2017
@valorkin valorkin merged commit 91fc1cd into development Jul 26, 2017
@valorkin valorkin deleted the fix-popover-container-class branch July 26, 2017 12:05
@codecov
Copy link

codecov bot commented Jul 26, 2017

Codecov Report

Merging #2283 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2283   +/-   ##
============================================
  Coverage        87.62%   87.62%           
============================================
  Files               95       95           
  Lines             2682     2682           
  Branches           359      359           
============================================
  Hits              2350     2350           
  Misses             209      209           
  Partials           123      123
Impacted Files Coverage Δ
src/popover/popover.directive.ts 91.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691c378...2dea428. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants