Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): using icons instead of innerHTML chevrons to fix iss… #2166

Merged
merged 1 commit into from
Jul 18, 2017
Merged

fix(datepicker): using icons instead of innerHTML chevrons to fix iss… #2166

merged 1 commit into from
Jul 18, 2017

Conversation

artdias90
Copy link
Contributor

…ue with webworkers

@codecov
Copy link

codecov bot commented Jul 3, 2017

Codecov Report

Merging #2166 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2166   +/-   ##
============================================
  Coverage        87.16%   87.16%           
============================================
  Files               85       85           
  Lines             2267     2267           
  Branches           293      293           
============================================
  Hits              1976     1976           
  Misses             188      188           
  Partials           103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5e135...ca2b55e. Read the comment docs.

@artdias90
Copy link
Contributor Author

@valorkin any chance you can take a look at this soon? it's a small one and would help me out a lot so I don't need to use my fork any longer

@valorkin
Copy link
Member

problem with this is:

const TEMPLATE_OPTIONS: any = {
  'bs4': {
    ARROW_LEFT: '&lt;',
    ARROW_RIGHT: '&gt;'
  },
  'bs3': {
    ARROW_LEFT: `
    <i class="glyphicon glyphicon-chevron-left"></i>
    `,
    ARROW_RIGHT: `
    <i class="glyphicon glyphicon-chevron-right"></i>
    `
  }
};

so this PR will break bs4 view,
you can add *ngIf=isBs4 and add corresponding elements

…ue with webworkers

fix(daypicker): condittionally using chevron based on bs

removed unused interface for templates

not using span anymore
@artdias90
Copy link
Contributor Author

artdias90 commented Jul 12, 2017

remove this TEMPLATE_OPTIONS object since we dont use anymore. @valorkin lmk

@valorkin valorkin merged commit 2fedac2 into valor-software:development Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants