Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): fix removing tabs in IE #2145

Merged
merged 1 commit into from
Jul 12, 2017
Merged

fix(tabs): fix removing tabs in IE #2145

merged 1 commit into from
Jul 12, 2017

Conversation

IlyaSurmay
Copy link
Contributor

Fixed unit tests for tabs in IE

@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #2145 into development will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2145   +/-   ##
============================================
  Coverage        87.16%   87.16%           
============================================
  Files               85       85           
  Lines             2267     2267           
  Branches           293      293           
============================================
  Hits              1976     1976           
  Misses             188      188           
  Partials           103      103
Impacted Files Coverage Δ
src/tabs/tabset.component.ts 84.12% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46419e3...e6696a8. Read the comment docs.

@IlyaSurmay IlyaSurmay requested a review from valorkin June 29, 2017 12:19
@valorkin valorkin changed the title test(tabs): fix ie tests fix(tabs): fix removing tabs in IE Jul 12, 2017
@valorkin valorkin merged commit fc5e135 into development Jul 12, 2017
@valorkin valorkin deleted the fix-ie-tests branch July 12, 2017 08:11
GulajavaMinistudio added a commit to GulajavaMinistudio/ngx-bootstrap that referenced this pull request Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants