feat(timepicker): new timepicker implementation #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2058 +/- ##
==============================================
+ Coverage 87.16% 88.66% +1.5%
==============================================
Files 85 95 +10
Lines 2267 2921 +654
Branches 293 414 +121
==============================================
+ Hits 1976 2590 +614
- Misses 188 219 +31
- Partials 103 112 +9
Continue to review full report at Codecov.
|
Closed
valorkin
force-pushed
the
feat-timepicker
branch
from
c521e29
to
5a80a12
Compare
valorkin
force-pushed
the
feat-timepicker
branch
from
6c4ae2f
to
1f8db8b
Compare
valorkin
force-pushed
the
feat-timepicker
branch
from
e22373d
to
eb31cae
Compare
IlyaSurmay
force-pushed
the
feat-timepicker
branch
from
f2a47df
to
4f85f8e
Compare
IlyaSurmay
force-pushed
the
feat-timepicker
branch
from
4f85f8e
to
083e8e8
Compare
* feat(timepicker): add inputs validation * fix(timepicker): add isPM support * feat(timepicker): add isValid output
|
|
|
Changes works normally - checked |
This was referenced Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2036
fixes #1981 ( + min max demo )
fixes #1973
close #1957 ( + seconds demo )
fixes #1935
fixes #1672
feat #1007 added keyboard and mousewheel support
fixes #962
fixes #793
fixes #173
fixes #1271 added custom validation demo
fixes #1539 bs4
fixes #1253 if input is invalid
todo