-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(positioning): auto option for positioning #1986
feat(positioning): auto option for positioning #1986
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1986 +/- ##
==============================================
Coverage ? 86.18%
==============================================
Files ? 78
Lines ? 2113
Branches ? 280
==============================================
Hits ? 1821
Misses ? 198
Partials ? 94
Continue to review full report at Codecov.
|
tried different scenarios and there some positioning issues |
+1 Very nice feature, hope it get fixed and merged soon! @IlyaSurmay please, give us some sample code of the positioning issue happening. Maybe I can help. Thanks |
+1 |
@valorkin @IlyaSurmay could you please merge this code? |
+1 |
1 similar comment
+1 |
+1 ETA on when this will be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything fine to me!
Concistensy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is fine :)
@vfcosta thanks for PR! |
feat(positioning): auto option for positioning (valor-software#1986)
This pull request is a proposal to solve #1111.