Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(positioning): auto option for positioning #1986

Merged
merged 3 commits into from
Aug 29, 2017

Conversation

vfcosta
Copy link
Contributor

@vfcosta vfcosta commented May 19, 2017

This pull request is a proposal to solve #1111.

@codecov
Copy link

codecov bot commented May 19, 2017

Codecov Report

❗ No coverage uploaded for pull request base (development@9f833eb). Click here to learn what that means.
The diff coverage is 76.47%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1986   +/-   ##
==============================================
  Coverage               ?   86.18%           
==============================================
  Files                  ?       78           
  Lines                  ?     2113           
  Branches               ?      280           
==============================================
  Hits                   ?     1821           
  Misses                 ?      198           
  Partials               ?       94
Impacted Files Coverage Δ
src/popover/popover.config.ts 100% <ø> (ø)
src/popover/popover.directive.ts 100% <100%> (ø)
src/positioning/ng-positioning.ts 75.72% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f833eb...9bd0abe. Read the comment docs.

@valorkin
Copy link
Member

valorkin commented Jun 1, 2017

tried different scenarios and there some positioning issues
@IlyaSurmay knew more details
we will get to this later a bit

@evandrojr
Copy link

+1 Very nice feature, hope it get fixed and merged soon!

@IlyaSurmay please, give us some sample code of the positioning issue happening. Maybe I can help.

Thanks

@leandronunes
Copy link

+1

@leandronunes
Copy link

@valorkin @IlyaSurmay could you please merge this code?

@Valery-vs
Copy link

+1

1 similar comment
@evandrojr
Copy link

+1

@cannontechnology
Copy link

cannontechnology commented Jul 25, 2017

+1 ETA on when this will be merged?

Copy link

@evandrojr evandrojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything fine to me!

@valorkin valorkin added this to the v1.9.2 milestone Aug 29, 2017
Copy link
Contributor

@EvilAlexei EvilAlexei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fine :)

@valorkin valorkin merged commit 114ed42 into valor-software:development Aug 29, 2017
@valorkin
Copy link
Member

@vfcosta thanks for PR!

GulajavaMinistudio added a commit to GulajavaMinistudio/ngx-bootstrap that referenced this pull request Aug 30, 2017
feat(positioning): auto option for positioning (valor-software#1986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants