Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed modal onShow #1155

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Fixed modal onShow #1155

merged 1 commit into from
Oct 26, 2016

Conversation

CodingDK
Copy link
Contributor

Fixed onShown event on modals so that the event not will be fired 2 times anymore.
Before this commit it will be fired 2 times.

Fixed onShown event on modals so that the event not will be fired 2 times anymore
@codecov-io
Copy link

codecov-io commented Oct 24, 2016

Current coverage is 85.62% (diff: 100%)

Merging #1155 into development will not change coverage

@@           development      #1155   diff @@
=============================================
  Files               35         35          
  Lines             1280       1280          
  Methods            228        228          
  Messages             0          0          
  Branches           213        213          
=============================================
  Hits              1096       1096          
  Misses             184        184          
  Partials             0          0          

Powered by Codecov. Last update 045573b...188c620

@valorkin
Copy link
Member

oh, it is a misprint
it should onBeforeShow event fired at that place
so you can prevent showing modals in last moment
same for closing, but this event was skipped for now
thanks for pointing! :)

@valorkin valorkin merged commit f74c1fb into valor-software:development Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants