Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination: allow setting of a custom css class on <li> #1115

Merged
merged 3 commits into from
Oct 26, 2016

Conversation

SylTi
Copy link
Contributor

@SylTi SylTi commented Oct 12, 2016

Make possible <li class="btn btn-primary"> for example

@codecov-io
Copy link

codecov-io commented Oct 12, 2016

Current coverage is 85.62% (diff: 100%)

Merging #1115 into development will not change coverage

@@           development      #1115   diff @@
=============================================
  Files               35         35          
  Lines             1280       1280          
  Methods            228        228          
  Messages             0          0          
  Branches           213        213          
=============================================
  Hits              1096       1096          
  Misses             184        184          
  Partials             0          0          

Powered by Codecov. Last update ec6ccc3...d1a3852

@valorkin
Copy link
Member

need to think about it a sec,

  1. classLi property doesn't describe what it does
  2. class="{{ classLi }} " need to check will it work with[class]="classLi"`

@valorkin valorkin self-assigned this Oct 13, 2016
@SylTi
Copy link
Contributor Author

SylTi commented Oct 13, 2016

  1. I can change the name to something li;e setLiClass if you want (I'm open to suggestions).
  2. [class] overwrite all existing class. That's not what we want

@valorkin
Copy link
Member

  1. by meaning it seems to be pageBtnClass ? seems to be pretty intuitive name
  2. what about [ngClass] ?

@SylTi
Copy link
Contributor Author

SylTi commented Oct 13, 2016

  1. Fine by me I will change it to that and push the new commit.
  2. It won't work for the pager already have : [ngClass]="{'pull-right': align}"

@valorkin
Copy link
Member

what I am afraid of: if pageBtnClass will change after disable changed, it can overwrite the whole class

@SylTi
Copy link
Contributor Author

SylTi commented Oct 13, 2016

By setting the property to `btn btn-primary' :

https://postimg.org/image/e5s4zkz2x/

Disable seems to work fine.

@valorkin
Copy link
Member

yes, now it looks much more readable,
if you are in hurry I can merge and publish it is as @beta now and cover with tests later
or you can cover it with test now

@SylTi
Copy link
Contributor Author

SylTi commented Oct 15, 2016

I will try to do the tests this weekend !

@SylTi
Copy link
Contributor Author

SylTi commented Oct 16, 2016

Is there no existing test for the pagination ? Can't find the .spec

@valorkin valorkin merged commit 235215c into valor-software:development Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants