Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo): fix routing functionality for links with inner html tags for demo pages #3813

Closed
ghost opened this issue Feb 16, 2018 · 1 comment
Closed

fix(demo): fix routing functionality for links with inner html tags for demo pages #3813

ghost opened this issue Feb 16, 2018 · 1 comment
Labels
comp(demo)

Comments

@ghost
Copy link

ghost commented Feb 16, 2018 •
edited by ghost
Loading

Fix routing for links on demo pages with href="#" and inner html tags.

Actrual result

If there is any inner html tag inside link, for example <a href="#"><span>Some text</span></a>,
this link will redirect to homepage.

Expected result

All links on demo pages with href = # should do nothing, even with inner html tags
@ghost
Copy link
Author

ghost commented Feb 16, 2018

effort1: easy(hours)

@ghost ghost changed the title fix(demo): fix dropdown link fix(demo): fix routing functionality for custom html inside dropdown item Feb 16, 2018
@ghost ghost changed the title fix(demo): fix routing functionality for custom html inside dropdown item fix(demo): fix routing functionality for links with inner html tags for demo pages Feb 16, 2018
@ghost ghost mentioned this issue Feb 16, 2018
Merged
@ghost ghost removed the in progress label Mar 1, 2018
valorkin pushed a commit that referenced this issue Mar 1, 2018
@valorkin
fix(demo): Fixed routings issue for links with inner html tags (#3816)
5869afb 
Closes #3813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(demo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EvilAlexei