-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover with triggers="focus" not working on MacOs #1795
Comments
interesting |
Having the same issue. Firefox on windows doesn't like the focus trigger. |
Same issue here on Mac Chrome, Firefox & Safari. |
Facing the same issue. triggers=focus not working on Firefox Mac |
Having the same issue on mac with chrome firefox and safari, but works perfectly on windows using Microsoft Edge. |
The same issue for me with Firefox OSX & Safari on our project. Do you have any idea about potential fix or should we give up your solution ? |
ok, it seems to be as designed (by browsers) |
@valorkin
doesn't work for us. We already have the problem on Safari and Firefox. Please reopen the issue (or accept my pull request). |
Hi, Gilsdav is damn right, that workaround is useless. You should merge his fix... |
fix(popover): no focus on button on Mac OS valor-software#1795 (valor-software#2031)
Use instead of and add tabindex="0". This solved the issue for me. |
tabindex="0" did not solve the problem |
Have you tried v3.3.0? |
no. is this problem is solved in v3.3.0 ? |
positioning service was completely reworked |
Its better than the previous but still not hiding if I clicking outside the poopover but it is hiding if I am clicking other button for other poopover |
On our projects and on your demo site, the popover with focus trigger doesn't work on Safari and Firefox (MacOsx). But it works on Chrome (MacOsx).
The original popover bootstrap works but not ng2-bootstrap popover.
https://www.quirksmode.org/dom/events/blurfocus.html
Within my test: On FF Mac, we can see the popover using tab key but not by clicking. On Safari, keyboard doesn't work.
A js fix to be able to handle focus event on button: http://jsfiddle.net/kzfg0pdh/6/
Temporary fix
On component that directly use popover:
Use this on HTML
triggers="focus:blur"
On ts
ngAfterViewInit() { const sels: any = document.querySelectorAll('[triggers]'); for (let i = 0; i < sels.length; i++) { sels[i].addEventListener('click', function() { sels[i].focus(); }); } }
The text was updated successfully, but these errors were encountered: