Skip to content

Commit

Permalink
fix(modal): change method call sequence (#5944)
Browse files Browse the repository at this point in the history
* fix(modal): change method call sequence

* fix(modal): fix for typo in dismiss reason string

Co-authored-by: Ankit Mishra <ankitmishra@Ankit-MacBook-Pro.local>
  • Loading branch information
cankitm and Ankit Mishra authored Oct 1, 2020
1 parent bf25a11 commit f5e79c8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/modal/modal-container.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ export class ModalContainerComponent implements OnInit, OnDestroy {

@HostListener('window:popstate')
onPopState(): void {
this.hide();
this.bsModalService.setDismissReason(DISMISS_REASONS.BACK);
this.hide();
}

@HostListener('window:keydown.esc', ['$event'])
Expand Down
2 changes: 1 addition & 1 deletion src/modal/modal-options.class.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,5 +90,5 @@ export const TRANSITION_DURATIONS: TransitionDurations = {
export const DISMISS_REASONS: DismissReasons = {
BACKRDOP: 'backdrop-click',
ESC: 'esc',
BACK: 'broswer-back-navigation-clicked'
BACK: 'browser-back-navigation-clicked'
};

0 comments on commit f5e79c8

Please sign in to comment.