fix(popover): prevent ng router active link double ngOnInit issue

valor-software · Jun 2, 2017 · dab394c · dab394c
1 parent 6bfd8e6
commit dab394c
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/popover/popover.directive.ts b/src/popover/popover.directive.ts
@@ -54,6 +54,7 @@ export class PopoverDirective implements OnInit, OnDestroy {
   @Output() public onHidden: EventEmitter<any>;
 
   private _popover: ComponentLoader<PopoverContainerComponent>;
+  private _isInited = false;
 
   public constructor(_elementRef: ElementRef,
                      _renderer: Renderer,
@@ -113,6 +114,12 @@ export class PopoverDirective implements OnInit, OnDestroy {
   }
 
   public ngOnInit(): any {
+    // fix: seems there are an issue with `routerLinkActive`
+    // which result in duplicated call ngOnInit without call to ngOnDestroy
+    // read more: https://github.com/valor-software/ngx-bootstrap/issues/1885
+    if (this._isInited) { return; }
+    this._isInited = true;
+
     this._popover.listen({
       triggers: this.triggers,
       show: () => this.show()