Skip to content

Commit

Permalink
Merge branch 'development' into patch-5
Browse files Browse the repository at this point in the history
  • Loading branch information
daniloff200 authored Nov 4, 2019
2 parents 6a583aa + 6adf5f0 commit cb07663
Show file tree
Hide file tree
Showing 101 changed files with 1,142 additions and 194 deletions.
25 changes: 0 additions & 25 deletions .github/ISSUE_TEMPLATE.md

This file was deleted.

37 changes: 37 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report-.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
---
name: Bug Report!
about: Report a bug to help us fix it
title: ''
labels: bug
assignees: ''

---

Before opening an issue, please search for duplicates (opened and closed) https://github.com/valor-software/ngx-bootstrap/issues There's no need to open an issue here if you want to ask general question, use StackOverflow or Slack instead

Bug description:

Plunker/StackBlitz that reproduces the issue:


Using Plunkr, StackBlitz is the best way to show your issue. Issues without link to an example of reproduction might be closed.

You can use one of starter templates:

Plunkr: https://plnkr.co/edit/0NipkZrnckZZROAcnjzB?p=preview

StackBlitz: https://stackblitz.com/edit/ngx-bootstrap?file=app%2Fapp.module.ts

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap:

Angular:

Bootstrap:

Build system: Angular CLI, System.js, webpack, starter seed:

**Expected behavior**

A clear and concise description of what you expected to happen.
27 changes: 27 additions & 0 deletions .github/ISSUE_TEMPLATE/feature-request-.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
name: Feature Request!
about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

**Is your feature request related to a problem? Please describe.**

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**

A clear and concise description of what you want to happen.


**Describe alternatives you've considered**


A clear and concise description of any alternative solutions or features you've considered.


**Additional context**

Add any other context or screenshots about the feature request here.
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/something-else-.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
name: Something Else?
about: Use this to report something that you don't think fits in as a bug report or
a feature request!
title: ''
labels: ''
assignees: ''

---

**Description:**
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ stages:
if: branch = development AND type = push OR tag =~ ^v\d+

before_install:
- export NG_CLI_ANALYTICS=ci
- rm -rf node_modules/ngx-bootstrap
- sudo apt-get install libgconf-2-4
- npm install tslint
Expand Down
68 changes: 67 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,70 @@
<a name="5.3.2"></a>
## [5.3.2](https://github.com/valor-software/ngx-bootstrap/compare/v5.3.1...v5.3.2) (2019-10-28)


### Bug Fixes

* **datepicker:** fix utc option issue ([#5534](https://github.com/valor-software/ngx-bootstrap/issues/5534)) ([04e6aad](https://github.com/valor-software/ngx-bootstrap/commit/04e6aad))


### Features

* **datepicker:** add Latvian locale (#hacktoberfest) ([#5432](https://github.com/valor-software/ngx-bootstrap/issues/5432)) ([9df0788](https://github.com/valor-software/ngx-bootstrap/commit/9df0788))



<a name="5.3.1"></a>
## [5.3.1](https://github.com/valor-software/ngx-bootstrap/compare/v5.3.0...v5.3.1) (2019-10-25)


### Bug Fixes

* **datepicker:** fix timezone regression && add useUtc option ([#5526](https://github.com/valor-software/ngx-bootstrap/issues/5526)) ([6742ce3](https://github.com/valor-software/ngx-bootstrap/commit/6742ce3))
* **datepicker:** skip years reordering if minMode='year' ([#5346](https://github.com/valor-software/ngx-bootstrap/issues/5346)) ([f0d8ab3](https://github.com/valor-software/ngx-bootstrap/commit/f0d8ab3))
* **doc:** fix aot.md ([#5459](https://github.com/valor-software/ngx-bootstrap/issues/5459)) ([2b0699f](https://github.com/valor-software/ngx-bootstrap/commit/2b0699f))
* **doc:** fix broken image link for 'Sauce Labs' ([#5483](https://github.com/valor-software/ngx-bootstrap/issues/5483)) ([97e5bbb](https://github.com/valor-software/ngx-bootstrap/commit/97e5bbb))
* **doc:** fix of file name mistake ([#5457](https://github.com/valor-software/ngx-bootstrap/issues/5457)) ([13bba2e](https://github.com/valor-software/ngx-bootstrap/commit/13bba2e)), closes [#5456](https://github.com/valor-software/ngx-bootstrap/issues/5456)
* **doc:** fix typo inside CONTRIBUTING.md ([#5486](https://github.com/valor-software/ngx-bootstrap/issues/5486)) ([d595023](https://github.com/valor-software/ngx-bootstrap/commit/d595023))
* **doc:** fix typo inside documentation component ([#5476](https://github.com/valor-software/ngx-bootstrap/issues/5476)) ([60ee719](https://github.com/valor-software/ngx-bootstrap/commit/60ee719))
* **progressbar:** fix e2e for progressbar ([#5494](https://github.com/valor-software/ngx-bootstrap/issues/5494)) ([0ed21d5](https://github.com/valor-software/ngx-bootstrap/commit/0ed21d5))
* **tests:** add fixes for datepicker e2e tests stability (manual_trigger && themes_spec) ([#5510](https://github.com/valor-software/ngx-bootstrap/issues/5510)) ([b82beba](https://github.com/valor-software/ngx-bootstrap/commit/b82beba))
* **tests:** fix e2e pagination ([#5528](https://github.com/valor-software/ngx-bootstrap/issues/5528)) ([849c813](https://github.com/valor-software/ngx-bootstrap/commit/849c813))
* **tests:** stabilize e2e tests ([#5512](https://github.com/valor-software/ngx-bootstrap/issues/5512)) ([68db502](https://github.com/valor-software/ngx-bootstrap/commit/68db502))
* **typeahead:** fix typeahead performance on typeaheadMinLength = 0 ([#5525](https://github.com/valor-software/ngx-bootstrap/issues/5525)) ([1035c0b](https://github.com/valor-software/ngx-bootstrap/commit/1035c0b))


### Features

* **common:** add discovery page ([#5332](https://github.com/valor-software/ngx-bootstrap/issues/5332)) ([1723e5b](https://github.com/valor-software/ngx-bootstrap/commit/1723e5b))
* **doc:** update demo(pagination) rotate button with dynamic behavior ([#5516](https://github.com/valor-software/ngx-bootstrap/issues/5516)) ([ed65226](https://github.com/valor-software/ngx-bootstrap/commit/ed65226)), closes [#5401](https://github.com/valor-software/ngx-bootstrap/issues/5401)
* **timepicker:** add custom placeholder ([#3544](https://github.com/valor-software/ngx-bootstrap/issues/3544)) ([#5429](https://github.com/valor-software/ngx-bootstrap/issues/5429)) ([05a215c](https://github.com/valor-software/ngx-bootstrap/commit/05a215c))



<a name="5.3.0"></a>
# [5.3.0](https://github.com/valor-software/ngx-bootstrap/compare/v5.2.0...v5.3.0) (2019-10-11)


### Bug Fixes

* **accordion, datepicker:** prevent accidental form submissions ([#5314](https://github.com/valor-software/ngx-bootstrap/issues/5314)) ([2ed2473](https://github.com/valor-software/ngx-bootstrap/commit/2ed2473))
* **datepicker:** need to update inline datepicker on input change ([#5436](https://github.com/valor-software/ngx-bootstrap/issues/5436)) ([534221d](https://github.com/valor-software/ngx-bootstrap/commit/534221d))
* **docs:** fix various typos ([#5467](https://github.com/valor-software/ngx-bootstrap/issues/5467)) ([2676683](https://github.com/valor-software/ngx-bootstrap/commit/2676683))
* **docs:** update join slack link ([#5421](https://github.com/valor-software/ngx-bootstrap/issues/5421)) ([b0a448b](https://github.com/valor-software/ngx-bootstrap/commit/b0a448b))
* **progressbar:** fix type class name binding override ([#5441](https://github.com/valor-software/ngx-bootstrap/issues/5441)) ([a544f44](https://github.com/valor-software/ngx-bootstrap/commit/a544f44))
* **timepicker:** fix placeholder full length ([#5392](https://github.com/valor-software/ngx-bootstrap/issues/5392)) ([bb5452b](https://github.com/valor-software/ngx-bootstrap/commit/bb5452b))
* **travis:** fix next stage ([#5419](https://github.com/valor-software/ngx-bootstrap/issues/5419)) ([6af8416](https://github.com/valor-software/ngx-bootstrap/commit/6af8416))


### Features

* **chronos:** add uk locale resolve [#5351](https://github.com/valor-software/ngx-bootstrap/issues/5351) ([#5396](https://github.com/valor-software/ngx-bootstrap/issues/5396)) ([f2187ea](https://github.com/valor-software/ngx-bootstrap/commit/f2187ea))
* **datepicker:** add invalidDate key to croatian locale ([#5393](https://github.com/valor-software/ngx-bootstrap/issues/5393)) ([b6c2036](https://github.com/valor-software/ngx-bootstrap/commit/b6c2036))
* **dropdown:** add animation to the component ([#5475](https://github.com/valor-software/ngx-bootstrap/issues/5475)) ([d70f08b](https://github.com/valor-software/ngx-bootstrap/commit/d70f08b))
* **progressbar:** create type interface ([#5440](https://github.com/valor-software/ngx-bootstrap/issues/5440)) ([6696623](https://github.com/valor-software/ngx-bootstrap/commit/6696623))



<a name="5.2.0"></a>
# [5.2.0](https://github.com/valor-software/ngx-bootstrap/compare/v5.1.2...v5.2.0) (2019-09-13)

Expand Down Expand Up @@ -2071,4 +2138,3 @@ sample: `<ul dropdownMenu>` should become `<ul *dropdownMenu>`
* **ng 2.0.37:** ts errors fixed ([1e19f55](https://github.com/valor-software/ngx-bootstrap/commit/1e19f55))
* **typeahead:** ts style fixes ([3eab1e4](https://github.com/valor-software/ngx-bootstrap/commit/3eab1e4))


20 changes: 10 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,18 @@ and help you to craft the change so that it is successfully accepted into the pr

Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.

We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs we will systematically ask you to provide a minimal reproduction scenario using [plunker]. Having a live, reproducible scenario gives us wealth of important information without going back & forth to you with additional questions like:
We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. To reproduce bugs we will systematically ask you to provide a minimal reproduction scenario using [plunker]. Having a live, reproducible scenario gives us a wealth of important information without going back & forth to you with additional questions like:

- version of Angular used
- the version of Angular used
- version on ngx-bootstrap used
- build system: angular cli, system.js, starter seed used
- and most importantly - a use-case that fails

A minimal reproduce scenario using [plunker] allows us to quickly confirm a bug (or point out coding problem) as well as confirm that we are fixing the right problem. If plunker is not a suitable way to demonstrate the problem (for example for issues related to our npm packaging), please create a standalone git repository demonstrating the problem.

We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. Interestingly, from our experience users often find coding problems themselves while preparing a minimal plunk. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.
We will be insisting on a minimal reproduce scenario to save maintainers time and ultimately be able to fix more bugs. Interestingly, from our experience users often find coding problems themselves while preparing a minimal plunk. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.

Unfortunately we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that don't have enough info to be reproduced.
Unfortunately we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.

You can file new issues by filling out our [new issue form](https://github.com/valor-software/ngx-bootstrap/issues/new).

Expand All @@ -88,7 +88,7 @@ Before you submit your Pull Request (PR) consider the following guidelines:
```shell
git commit -a
```
Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.
Note: the optional commit `-a` command-line option will automatically "add" and "rm" edited files.

* Push your branch to GitHub:

Expand Down Expand Up @@ -163,7 +163,7 @@ The **header** is mandatory and the **scope** of the header is optional.
Any line of the commit message cannot be longer 100 characters! This allows the message to be easier
to read on GitHub as well as in various git tools.

Footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.
The footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.

Samples: (even more [samples](https://github.com/valor-software/ngx-bootstrap/commits/development))

Expand All @@ -177,7 +177,7 @@ The version in our package.json gets copied to the one we publish, and users nee
```

### Revert
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. In the body, it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.

### Type
Must be one of the following:
Expand Down Expand Up @@ -219,18 +219,18 @@ The following is the list of supported scopes:
The subject contains succinct description of the change:

* use the imperative, present tense: "change" not "changed" nor "changes"
* don't capitalize first letter
* don't capitalize the first letter
* no dot (.) at the end
### Body
Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes".
The body should include the motivation for the change and contrast this with previous behavior.
The body should include the motivation for the change and contrast this with previous behaviour.
### Footer
The footer should contain any information about **Breaking Changes** and is also the place to
reference GitHub issues that this commit **Closes**.
**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this.
**Breaking Changes** should start with the word `BREAKING CHANGE:` with space or two newlines. The rest of the commit message is then used for this.
A detailed explanation can be found in this [document][commit-message-format].
Expand Down
Loading

0 comments on commit cb07663

Please sign in to comment.