Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified code so that table works with angular 2 rc1 #140

Merged
merged 3 commits into from
May 18, 2016

Conversation

shahmirn
Copy link
Contributor

Fixes issue #135

@shahmirn shahmirn changed the title Make code compile with angular 2 rc1 Modified code so that table works with angular 2 rc1 May 12, 2016
@valorkin
Copy link
Member

Looks good! Thanks for your help!

@vladjerca
Copy link

@shahmirn
The branch works, although you did not update the HTML template loops to use 'let'.

'ng-table.component.ts'

<tr *ngFor="#row of rows">
        <td *ngFor="#column of columns">{{getData(row, column.name)}}</td>
</tr>

Should be:

<tr *ngFor="let row of rows">
        <td *ngFor="let column of columns">{{getData(row, column.name)}}</td>
</tr>

I think must be done before this gets merged, these have been marked as deprecated since beta15 if I'm not mistaken.

And thanks for taking the time to make the changes!

@valorkin valorkin self-assigned this May 17, 2016
@valorkin
Copy link
Member

Will be updated today, latest tomorrow

@valorkin valorkin merged commit 2cade91 into valor-software:master May 18, 2016
@valorkin
Copy link
Member

Merged, updating to release flow of other ng2 modules

@valorkin
Copy link
Member

Thanks for your help!

@valorkin
Copy link
Member

@shahmirn if you want to develop this module further I can give you write access
just drop me a note :)

@shahmirn
Copy link
Contributor Author

@valorkin Write access would be great. There's a few more features that I need for my use-case that I'll need to add, one of them being the ability to support mark-up in the columns.

@valorkin
Copy link
Member

Here we go :)
Welcome to ng2-team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants