Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too large control on firefox 50 #557

Open
Matiszak opened this issue Dec 16, 2016 · 1 comment
Open

Too large control on firefox 50 #557

Matiszak opened this issue Dec 16, 2016 · 1 comment

Comments

@Matiszak
Copy link
Contributor

Matiszak commented Dec 16, 2016 •
edited
Loading

On Firefox 50 latest version of ng2-select (1.2.1) is too large when using single select. After selection the size is goes back to normal.
ng2-select too high

Settings:
Firefox50 + Angular 2.2.4 + Bootstrap4 alpha 5
@Matiszak
Copy link
Contributor Author

After fast looking: there are two spans - one for text and one for caret. Caret i being pulled right with pull-right => float:right. Firefox puts it in new line unless the text is as well floated.
Adding float:left to text span fixes the issue. Could you check if it fixes that and doesn't break anything and merge it ?

@Matiszak Matiszak mentioned this issue Dec 16, 2016
Merged
valorkin pushed a commit that referenced this issue Dec 21, 2016
@Matiszak @valorkin
#557: Fix rendering select component on firefox (#559)
77ddc89 
#557: Fixed visual error on firefox. In single-select mode select
component had extended height due to caret symbol going into new line.
Added float:left to placeholder class to fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Matiszak