Fix bug in writeToClient during refactoring I/O threading #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranshid
approved these changes
Jul 28, 2024
|
@uriyage Please fix the DCO. |
madolson
added
the
pending-missing-dco
Signed-off-by: Uri Yagelnik <uriy@amazon.com>
uriyage
force-pushed
the
fix_write_to_client
branch
from
f439cbc to
25d0482
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #834 +/- ##
============================================
+ Coverage 70.20% 70.38% +0.17%
============================================
Files 112 112
Lines 61462 61462
============================================
+ Hits 43152 43262 +110
+ Misses 18310 18200 -110
|
enjoy-binbin
approved these changes
Jul 29, 2024
madolson
approved these changes
Jul 31, 2024
madolson
changed the title
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 22, 2024
Fix bug in writeToClient In valkey-io#758, a major refactor was done to `networking.c`. As part of this refactor, a new bug was introduced: we don't advance the `c->buf` pointer in repeated writes. This bug should be very unlikely to manifest, as it requires the client's TCP buffer to be filled in the first try and then released immediately after in the second try. Despite all my efforts to reproduce this scenario, I was unable to do so. Signed-off-by: Uri Yagelnik <uriy@amazon.com> Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in writeToClient
In #758, a major refactor was done to
networking.c.As part of this refactor, a new bug was introduced: we don't advance the
c->bufpointer in repeated writes.This bug should be very unlikely to manifest, as it requires the client's TCP buffer to be filled in the first try and then released immediately after in the second try.
Despite all my efforts to reproduce this scenario, I was unable to do so.