Fix flaky cluster automatic failover test#3206
Merged
enjoy-binbin merged 1 commit intovalkey-io:unstablefrom Feb 17, 2026
Merged
Fix flaky cluster automatic failover test#3206enjoy-binbin merged 1 commit intovalkey-io:unstablefrom
enjoy-binbin merged 1 commit intovalkey-io:unstablefrom
Conversation
The test somehow is slow and due to the short cluster-node-timeout, an automatic failover may fail to trigger due to cluster-replica-validity-factor: ``` *** [err]: Automatic failover vote is not limited by two times the node timeout - mixed failover in tests/unit/cluster/manual-failover.tcl The third failover does not happen xxx # Cluster state changed: fail xxx # Cluster is currently down: At least one hash slot is not served by any available node. Please check the 'cluster-require-full-coverage' configuration. ``` Closes valkey-io#3203. Signed-off-by: Binbin <binloveplay1314@qq.com>
Nikhil-Manglore
approved these changes
Feb 15, 2026
dvkashapov
approved these changes
Feb 16, 2026
zuiderkwast
approved these changes
Feb 16, 2026
Contributor
|
Let's backport it. Not sure which versions are affected. All? |
sarthakaggarwal97
approved these changes
Feb 16, 2026
Contributor
sarthakaggarwal97
left a comment
sarthakaggarwal97
left a comment
There was a problem hiding this comment.
Thanks @enjoy-binbin
Member
Author
|
We added it in 8.1 i think. |
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 17, 2026
The test somehow is slow and due to the short cluster-node-timeout, an automatic failover may fail to trigger due to cluster-replica-validity-factor: ``` *** [err]: Automatic failover vote is not limited by two times the node timeout - mixed failover in tests/unit/cluster/manual-failover.tcl The third failover does not happen xxx # Cluster state changed: fail xxx # Cluster is currently down: At least one hash slot is not served by any available node. Please check the 'cluster-require-full-coverage' configuration. ``` Closes valkey-io#3203. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 17, 2026
The test somehow is slow and due to the short cluster-node-timeout, an automatic failover may fail to trigger due to cluster-replica-validity-factor: ``` *** [err]: Automatic failover vote is not limited by two times the node timeout - mixed failover in tests/unit/cluster/manual-failover.tcl The third failover does not happen xxx # Cluster state changed: fail xxx # Cluster is currently down: At least one hash slot is not served by any available node. Please check the 'cluster-require-full-coverage' configuration. ``` Closes valkey-io#3203. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
The test somehow is slow and due to the short cluster-node-timeout, an automatic failover may fail to trigger due to cluster-replica-validity-factor: ``` *** [err]: Automatic failover vote is not limited by two times the node timeout - mixed failover in tests/unit/cluster/manual-failover.tcl The third failover does not happen xxx # Cluster state changed: fail xxx # Cluster is currently down: At least one hash slot is not served by any available node. Please check the 'cluster-require-full-coverage' configuration. ``` Closes valkey-io#3203. Signed-off-by: Binbin <binloveplay1314@qq.com>
roshkhatri
pushed a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 20, 2026
The test somehow is slow and due to the short cluster-node-timeout, an automatic failover may fail to trigger due to cluster-replica-validity-factor: ``` *** [err]: Automatic failover vote is not limited by two times the node timeout - mixed failover in tests/unit/cluster/manual-failover.tcl The third failover does not happen xxx # Cluster state changed: fail xxx # Cluster is currently down: At least one hash slot is not served by any available node. Please check the 'cluster-require-full-coverage' configuration. ``` Closes valkey-io#3203. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
madolson
pushed a commit
that referenced
this pull request
Feb 24, 2026
The test somehow is slow and due to the short cluster-node-timeout, an automatic failover may fail to trigger due to cluster-replica-validity-factor: ``` *** [err]: Automatic failover vote is not limited by two times the node timeout - mixed failover in tests/unit/cluster/manual-failover.tcl The third failover does not happen xxx # Cluster state changed: fail xxx # Cluster is currently down: At least one hash slot is not served by any available node. Please check the 'cluster-require-full-coverage' configuration. ``` Closes #3203. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
madolson
pushed a commit
that referenced
this pull request
Feb 24, 2026
The test somehow is slow and due to the short cluster-node-timeout, an automatic failover may fail to trigger due to cluster-replica-validity-factor: ``` *** [err]: Automatic failover vote is not limited by two times the node timeout - mixed failover in tests/unit/cluster/manual-failover.tcl The third failover does not happen xxx # Cluster state changed: fail xxx # Cluster is currently down: At least one hash slot is not served by any available node. Please check the 'cluster-require-full-coverage' configuration. ``` Closes #3203. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test somehow is slow and due to the short cluster-node-timeout, an automatic
failover may fail to trigger due to cluster-replica-validity-factor:
Closes #3203.